Bug 148766

Summary: WatchpointsOnStructureStubInfo doesn't need to be reference counted
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148718    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2015-09-03 18:13:28 PDT
It doesn't need to be reference counted because the only RefPtr to it is in StructureStubInfo. Therefore, it can be a unique_ptr.
Attachments
the patch (4.16 KB, patch)
2015-09-03 18:14 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-09-03 18:14:25 PDT
Created attachment 260546 [details] the patch
Saam Barati
Comment 2 2015-09-03 18:16:35 PDT
Comment on attachment 260546 [details] the patch r=me
Filip Pizlo
Comment 3 2015-09-03 18:21:15 PDT
Landed in http://trac.webkit.org/changeset/189328
Note You need to log in before you can comment on or make changes to this bug.