Bug 148742

Summary: Get rid of RepatchBuffer and replace it with static functions
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on: 148741, 148792    
Bug Blocks: 148743    
Attachments:
Description Flags
it's a start
none
getting close
none
the patch ggaren: review+

Description Filip Pizlo 2015-09-03 11:15:56 PDT 
Once RepatchBuffer is stateless, it won't make any sense to instantiate it or pass it around.
Comment 1 Filip Pizlo 2015-09-03 13:26:48 PDT 
Created attachment 260516 [details]
it's a start
Comment 2 Filip Pizlo 2015-09-03 13:47:36 PDT 
Created attachment 260518 [details]
getting close
Comment 3 Filip Pizlo 2015-09-03 13:57:57 PDT 
Created attachment 260519 [details]
the patch
Comment 4 Geoffrey Garen 2015-09-03 13:59:07 PDT 
Comment on attachment 260519 [details]
the patch

r=me
Comment 5 WebKit Commit Bot 2015-09-03 14:01:10 PDT 
Attachment 260519 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/JIT.h:183:  The parameter name "returnAddress" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Mark Lam 2015-09-03 14:05:19 PDT 
Comment on attachment 260519 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260519&action=review

r=me

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003
> -    <ClInclude Include="..\assembler\RepatchBuffer.h">
> -      <Filter>assembler</Filter>
> -    </ClInclude>

You also need to remove this from Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj
Comment 7 Filip Pizlo 2015-09-03 14:12:09 PDT 
(In reply to comment #6)
> Comment on attachment 260519 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260519&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003
> > -    <ClInclude Include="..\assembler\RepatchBuffer.h">
> > -      <Filter>assembler</Filter>
> > -    </ClInclude>
> 
> You also need to remove this from
> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj

Fixed, along with 32-bit builds.
Comment 8 Filip Pizlo 2015-09-03 14:12:30 PDT 
Landed in http://trac.webkit.org/changeset/189288