Bug 148741

Summary: RepatchBuffer should be stateless
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148742    
Attachments:
Description Flags
the patch
none
more fixes ggaren: review+

Description Filip Pizlo 2015-09-03 11:15:16 PDT 
We use the CodeBlock* field of RepatchBuffer in various places.  Usually, when we use this field, we're doing it wrong, since we never really know which CodeBlock* the RepatchBuffer points to.

Also, this field was there to support WX_EXCLUSIVE, which doesn't work anymore and probably never will (since nobody is working on it).  Killing that feature means that we no longer have to be careful about caching a RepatchBuffer and passing it around.
Comment 1 Filip Pizlo 2015-09-03 11:24:43 PDT 
Created attachment 260498 [details]
the patch
Comment 2 Filip Pizlo 2015-09-03 11:29:12 PDT 
Created attachment 260500 [details]
more fixes
Comment 3 Geoffrey Garen 2015-09-03 11:30:32 PDT 
Comment on attachment 260500 [details]
more fixes

r=me
Comment 4 Filip Pizlo 2015-09-03 12:42:12 PDT 
Landed in http://trac.webkit.org/changeset/189278