Bug 148725

Summary: Replace all the various forms of branchStructure() with a single method in AssemblyHelpers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148718    
Attachments:
Description Flags
the patch sbarati: review+

Description Filip Pizlo 2015-09-02 15:11:38 PDT
Currently there are the following branchStructure() implementations:

JSC::JIT::branchStructure()
JSC::branchStructure()
JSC::DFG::JITCompiler::branchStructure()

They all do the same thing.  There should only be one.
Comment 1 Filip Pizlo 2015-09-02 15:19:33 PDT
Created attachment 260446 [details]
the patch
Comment 2 Saam Barati 2015-09-02 15:24:30 PDT
Comment on attachment 260446 [details]
the patch

r=me
I like duplicate code removal.
Comment 3 Filip Pizlo 2015-09-02 20:17:32 PDT
Landed in http://trac.webkit.org/changeset/189272