Bug 148698

Summary: Web Inspector: Move PrettyPrinting tests into LayoutTests
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 148703    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-09-01 17:56:37 PDT
* SUMMARY Move PrettyPrinting tests into LayoutTests.
Attachments
[PATCH] Proposed Fix (54.06 KB, patch)
2015-09-01 18:01 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-01 17:57:05 PDT
<rdar://problem/22531096>
Joseph Pecoraro
Comment 2 2015-09-01 18:01:53 PDT
Created attachment 260398 [details] [PATCH] Proposed Fix Tests can still be run from WebInspectorUI/Tools/PrettyPrinting but they are now automatically run with LayoutTests/inspector tests.
WebKit Commit Bot
Comment 3 2015-09-01 18:56:12 PDT
Comment on attachment 260398 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260398 Committed r189241: <http://trac.webkit.org/changeset/189241>
WebKit Commit Bot
Comment 4 2015-09-01 18:56:14 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2015-09-01 22:06:57 PDT
Re-opened since this is blocked by bug 148703
Joseph Pecoraro
Comment 7 2015-09-02 16:00:31 PDT
Blocked by bug 148727, which should fix this ASSERT for us.
Joseph Pecoraro
Comment 8 2015-09-08 11:48:30 PDT
Remanded in: https://trac.webkit.org/r189500
Joseph Pecoraro
Comment 9 2015-09-08 13:50:56 PDT
Follow-up after Test.js magnification: http://trac.webkit.org/changeset/189505
Note You need to log in before you can comment on or make changes to this bug.