| Summary: | Web Inspector: Move PrettyPrinting tests into LayoutTests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 148703 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2015-09-01 17:56:37 PDT
Created attachment 260398 [details]
[PATCH] Proposed Fix
Tests can still be run from WebInspectorUI/Tools/PrettyPrinting but they are now automatically run with LayoutTests/inspector tests.
Comment on attachment 260398 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260398 Committed r189241: <http://trac.webkit.org/changeset/189241> All reviewed patches have been landed. Closing bug. These tests crash in debug, and sometimes fail in release: https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r189243%20(7198)/results.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r189243%20(7994)/results.html Will roll out. Re-opened since this is blocked by bug 148703 Blocked by bug 148727, which should fix this ASSERT for us. Remanded in: https://trac.webkit.org/r189500 Follow-up after Test.js magnification: http://trac.webkit.org/changeset/189505 |