Bug 148656

Summary:

[mediacontrols] Add tests for the status display label

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Media

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=148704

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Dean Jackson 2015-08-31 16:50:38 PDT

[mediacontrols] Add tests for the status display label

Comment 1 Radar WebKit Bug Importer 2015-08-31 16:51:44 PDT

<rdar://problem/22509779>

Comment 2 Dean Jackson 2015-08-31 16:56:03 PDT

Created attachment 260330 [details]
Patch

Comment 3 Eric Carlson 2015-08-31 18:25:11 PDT

Comment on attachment 260330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260330&action=review

> LayoutTests/ChangeLog:15
> +        * media/controls/statusDisplay-expected.txt: Added.
> +        * media/controls/statusDisplay.html: Added.
> +        * media/controls/statusDisplayBad-expected.txt: Added.
> +        * media/controls/statusDisplayBad.html: Added.

Shouldn't these be skipped on non-Apple ports?

> LayoutTests/media/controls/statusDisplay.html:28
> +                    showControlsButtonInfo = currentStatus

Nit: this isn't used.

> LayoutTests/media/controls/statusDisplayBad.html:27
> +                    showControlsButtonInfo = currentStatus

Ditto.

Comment 4 Dean Jackson 2015-09-01 10:39:38 PDT

Committed r189215: <http://trac.webkit.org/changeset/189215>

Comment 5 Alexey Proskuryakov 2015-09-01 22:30:57 PDT

A test added here is flaky, please see bug 148704.