Summary: | [EFL] Revise PlatformWebView ctor according to r188718 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||
Component: | WebKit EFL | Assignee: | Joonghun Park <jh718.park> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, mcatanzaro, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joonghun Park
2015-08-20 19:26:11 PDT
Created attachment 259565 [details]
Patch
Comment on attachment 259565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259565&action=review > Source/WebKit2/PlatformEfl.cmake:68 > + UIProcess/API/C/WKPageConfigurationRef.cpp Wrong alphabet order. Committed r188751: <http://trac.webkit.org/changeset/188751> (In reply to comment #3) > Committed r188751: <http://trac.webkit.org/changeset/188751> Land after fixing it. (In reply to comment #2) > Comment on attachment 259565 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > Source/WebKit2/PlatformEfl.cmake:68 > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > Wrong alphabet order. If I place files as below, UIProcess/API/C/CoordinatedGraphics/WKView.cpp UIProcess/API/C/WKPageConfigurationRef.cpp then when I run check-webkit-style script, I meet the log like this. Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp because the former is file name and the latter is an intermediate path name I think. So I guess the current alphabetical order is the right one. (In reply to comment #5) > (In reply to comment #2) > > Comment on attachment 259565 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > > > Source/WebKit2/PlatformEfl.cmake:68 > > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > > > Wrong alphabet order. > > If I place files as below, > > UIProcess/API/C/CoordinatedGraphics/WKView.cpp > UIProcess/API/C/WKPageConfigurationRef.cpp > > then when I run check-webkit-style script, I meet the log like this. > > Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. > "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before > "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". > > It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp > because the former is file name and the latter is an intermediate path name > I think. > > So I guess the current alphabetical order is the right one. Yes, it just needed to have a empty line. :) I fixed it. http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl.cmake (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > Comment on attachment 259565 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > > > > > Source/WebKit2/PlatformEfl.cmake:68 > > > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > > > > > Wrong alphabet order. > > > > If I place files as below, > > > > UIProcess/API/C/CoordinatedGraphics/WKView.cpp > > UIProcess/API/C/WKPageConfigurationRef.cpp > > > > then when I run check-webkit-style script, I meet the log like this. > > > > Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. > > "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before > > "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". > > > > It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp > > because the former is file name and the latter is an intermediate path name > > I think. > > > > So I guess the current alphabetical order is the right one. > > Yes, it just needed to have a empty line. :) I fixed it. > > http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl. > cmake Ah, I missed the empty line. Thank you :) |