Bug 148111

Summary: [Win] Switch to CMake
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148112, 148198, 148389    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch bfulgham: review+

Description Alex Christensen 2015-08-17 17:28:40 PDT 
Let's do it!  I'll accumulate the things that need to be done in the final switch here, and have dependent bugs to track my progress.
Comment 1 Alex Christensen 2015-08-17 17:38:37 PDT 
Created attachment 259216 [details]
Patch
Comment 2 Alex Christensen 2015-08-24 13:00:09 PDT 
Created attachment 259768 [details]
Patch
Comment 3 Alex Christensen 2015-08-27 14:46:50 PDT 
With this change, we'll have to switch the tools directory from WebKitLibraries/win/tools to Source/cmake.
Comment 4 Brent Fulgham 2015-08-31 17:41:13 PDT 
Comment on attachment 259768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259768&action=review

We need these to be Production, not Release. r- for that reason.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:6
> +	<CONFIG>Release</CONFIG>

No! No no no!

> Source/WTF/WTF.vcxproj/WTF.proj:6
> +	<CONFIG>Release</CONFIG>

No!

> Source/WebCore/WebCore.vcxproj/WebCore.proj:6
> +	<CONFIG>Release</CONFIG>

No!

> Source/WebKit/WebKit.vcxproj/WebKit.proj:6
> +	<CONFIG>Release</CONFIG>

No!
Comment 5 Alex Christensen 2015-09-25 14:45:10 PDT 
Created attachment 261940 [details]
Patch
Comment 6 Brent Fulgham 2015-09-25 14:46:46 PDT 
Comment on attachment 261940 [details]
Patch

r=me. Let's go for it!
Comment 7 Alex Christensen 2015-09-25 14:51:26 PDT 
http://trac.webkit.org/changeset/190253