Bug 148111

Summary: [Win] Switch to CMake
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148112, 148198, 148389    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch bfulgham: review+

Alex Christensen
Reported 2015-08-17 17:28:40 PDT
Let's do it! I'll accumulate the things that need to be done in the final switch here, and have dependent bugs to track my progress.
Attachments
Patch (6.86 KB, patch)
2015-08-17 17:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (37.54 KB, patch)
2015-08-24 13:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.00 KB, patch)
2015-09-25 14:45 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-17 17:38:37 PDT
Created attachment 259216 [details] Patch
Alex Christensen
Comment 2 2015-08-24 13:00:09 PDT
Created attachment 259768 [details] Patch
Alex Christensen
Comment 3 2015-08-27 14:46:50 PDT
With this change, we'll have to switch the tools directory from WebKitLibraries/win/tools to Source/cmake.
Brent Fulgham
Comment 4 2015-08-31 17:41:13 PDT
Comment on attachment 259768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259768&action=review We need these to be Production, not Release. r- for that reason. > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:6 > + <CONFIG>Release</CONFIG> No! No no no! > Source/WTF/WTF.vcxproj/WTF.proj:6 > + <CONFIG>Release</CONFIG> No! > Source/WebCore/WebCore.vcxproj/WebCore.proj:6 > + <CONFIG>Release</CONFIG> No! > Source/WebKit/WebKit.vcxproj/WebKit.proj:6 > + <CONFIG>Release</CONFIG> No!
Alex Christensen
Comment 5 2015-09-25 14:45:10 PDT
Created attachment 261940 [details] Patch
Brent Fulgham
Comment 6 2015-09-25 14:46:46 PDT
Comment on attachment 261940 [details] Patch r=me. Let's go for it!
Alex Christensen
Comment 7 2015-09-25 14:51:26 PDT
http://trac.webkit.org/changeset/190253
Note You need to log in before you can comment on or make changes to this bug.