Bug 148389 - Isolate Source directories in CMake build
Summary: Isolate Source directories in CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks: 148111
  Show dependency tree / graph
 
Reported: 2015-08-24 12:36 PDT by Alex Christensen
Modified: 2015-08-27 14:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2015-08-24 12:48 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (15.66 KB, patch)
2015-08-24 12:50 PDT, Alex Christensen 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-08-24 12:36:05 PDT 
Internal Windows build needs directories completely separated.
Comment 1 Alex Christensen 2015-08-24 12:48:25 PDT 
Created attachment 259765 [details]
Patch
Comment 2 Alex Christensen 2015-08-24 12:50:10 PDT 
Created attachment 259766 [details]
Patch
Comment 3 Csaba Osztrogonác 2015-08-25 03:19:01 PDT 
Comment on attachment 259766 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259766&action=review

> ChangeLog:10
> +        * CMakeLists.txt:
> +        * Source/cmake/WebKitCommon.cmake:
> +        Move package finding to WebKitCommon.

How is it related to this bug?
Comment 4 Alex Christensen 2015-08-25 10:21:49 PDT 
(In reply to comment #3)
> Comment on attachment 259766 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259766&action=review
> 
> > ChangeLog:10
> > +        * CMakeLists.txt:
> > +        * Source/cmake/WebKitCommon.cmake:
> > +        Move package finding to WebKitCommon.
> 
> How is it related to this bug?
A directory must be able to be built with only what is in it and Source/cmake in order to switch the Windows build to CMake.  Right now, it fails without this because finding things like Bison is done in ./CMakeLists.txt, which is not there when we are only building WTF, for example.
Comment 5 Brent Fulgham 2015-08-27 14:30:33 PDT 
Comment on attachment 259766 [details]
Patch

r=me
Comment 6 Alex Christensen 2015-08-27 14:37:31 PDT 
http://trac.webkit.org/changeset/189056