Bug 148112 - [Win CMake] Allow WebKitLibraries directory to be set from the command line
Summary: [Win CMake] Allow WebKitLibraries directory to be set from the command line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks: 148111
  Show dependency tree / graph
 
Reported: 2015-08-17 17:30 PDT by Alex Christensen
Modified: 2015-08-17 17:44 PDT (History)
0 users

See Also:

Attachments
Patch (5.99 KB, patch)
2015-08-17 17:34 PDT, Alex Christensen 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-08-17 17:30:24 PDT 
Environment variables aren't needed.  Let's use WebKitLibraries/win as a fallback if nothing is given from the command line.  This way, the internal build and the open source build can both work cleaner.
Comment 1 Alex Christensen 2015-08-17 17:34:55 PDT 
Created attachment 259215 [details]
Patch
Comment 2 Brent Fulgham 2015-08-17 17:41:00 PDT 
Comment on attachment 259215 [details]
Patch

r=me.
Comment 3 Alex Christensen 2015-08-17 17:44:20 PDT 
http://trac.webkit.org/changeset/188560