Bug 148003

Summary: Move some commands from ./CMakeLists.txt to Source/cmake
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, clopez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148015    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2015-08-13 16:57:54 PDT
When building everything separately like the Apple builds do, we need some functionality to be in Source/cmake instead of ./CMakeLists.txt to minimize the duplicate commands.
Attachments
Patch (8.30 KB, patch)
2015-08-13 17:02 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.21 KB, patch)
2015-08-17 13:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-13 17:02:16 PDT
Created attachment 258958 [details] Patch
Brent Fulgham
Comment 2 2015-08-13 17:05:01 PDT
Comment on attachment 258958 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-08-13 19:14:33 PDT
Comment on attachment 258958 [details] Patch Clearing flags on attachment: 258958 Committed r188428: <http://trac.webkit.org/changeset/188428>
WebKit Commit Bot
Comment 4 2015-08-13 19:14:39 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2015-08-13 21:49:47 PDT
Re-opened since this is blocked by bug 148015
Alex Christensen
Comment 6 2015-08-17 13:04:54 PDT
Created attachment 259172 [details] Patch
Alex Christensen
Comment 7 2015-08-17 13:06:05 PDT
This time I renamed OptionsWindows to OptionsWin and that fixed Windows. I'll reland this once it passes another CMake EWS.
Alex Christensen
Comment 8 2015-08-17 13:43:20 PDT
Recommitted to http://trac.webkit.org/changeset/188540
Xabier Rodríguez Calvar
Comment 9 2015-08-18 04:11:15 PDT
This creates a problem with building GTK+ from scratch, as you don't get WTR and I think you don't get the launcher either.
Xabier Rodríguez Calvar
Comment 10 2015-08-18 04:18:01 PDT
(In reply to comment #9) > This creates a problem with building GTK+ from scratch, as you don't get WTR > and I think you don't get the launcher either. And even after reverting this, I don't get WTR, so I guess there's something else.
Carlos Alberto Lopez Perez
Comment 11 2015-08-18 04:43:22 PDT
Also with the perf tests: $ Tools/Scripts/run-perf-tests --platform gtk --release WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build not up to date for /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner The issue is that WebKitTestRunner is not longer built: $ find WebKitBuild/Release/ -type f -executable WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_C.bin WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_CXX.bin WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdCXX/a.out WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdC/a.out WebKitBuild/Release/bin/WebKitNetworkProcess WebKitBuild/Release/bin/jsc WebKitBuild/Release/bin/WebKitDatabaseProcess WebKitBuild/Release/bin/WebKitPluginProcess WebKitBuild/Release/bin/WebKitPluginProcess2 WebKitBuild/Release/bin/LLIntOffsetsExtractor WebKitBuild/Release/bin/WebKitWebProcess WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18.2.4 WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so WebKitBuild/Release/lib/libgtest.so WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.10.0 This is probably the issue causing the GTK perf bot to fail on all the tests I'm going to open a bug for this regression
Carlos Alberto Lopez Perez
Comment 12 2015-08-18 04:49:22 PDT
Reported: https://bugs.webkit.org/show_bug.cgi?id=148127
Note You need to log in before you can comment on or make changes to this bug.