Summary: | Move some commands from ./CMakeLists.txt to Source/cmake | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, clopez, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 148015 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alex Christensen
2015-08-13 16:57:54 PDT
Created attachment 258958 [details]
Patch
Comment on attachment 258958 [details]
Patch
r=me
Comment on attachment 258958 [details] Patch Clearing flags on attachment: 258958 Committed r188428: <http://trac.webkit.org/changeset/188428> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 148015 Created attachment 259172 [details]
Patch
This time I renamed OptionsWindows to OptionsWin and that fixed Windows. I'll reland this once it passes another CMake EWS. Recommitted to http://trac.webkit.org/changeset/188540 This creates a problem with building GTK+ from scratch, as you don't get WTR and I think you don't get the launcher either. (In reply to comment #9) > This creates a problem with building GTK+ from scratch, as you don't get WTR > and I think you don't get the launcher either. And even after reverting this, I don't get WTR, so I guess there's something else. Also with the perf tests: $ Tools/Scripts/run-perf-tests --platform gtk --release WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build not up to date for /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner The issue is that WebKitTestRunner is not longer built: $ find WebKitBuild/Release/ -type f -executable WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_C.bin WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_CXX.bin WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdCXX/a.out WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdC/a.out WebKitBuild/Release/bin/WebKitNetworkProcess WebKitBuild/Release/bin/jsc WebKitBuild/Release/bin/WebKitDatabaseProcess WebKitBuild/Release/bin/WebKitPluginProcess WebKitBuild/Release/bin/WebKitPluginProcess2 WebKitBuild/Release/bin/LLIntOffsetsExtractor WebKitBuild/Release/bin/WebKitWebProcess WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18.2.4 WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so WebKitBuild/Release/lib/libgtest.so WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.10.0 This is probably the issue causing the GTK perf bot to fail on all the tests I'm going to open a bug for this regression |