Bug 147989

Summary: Add WKWindowFeaturesRef and a new modern createNewPage UI client callback
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148014    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Anders Carlsson
Reported 2015-08-13 13:51:03 PDT
Add WKWindowFeaturesRef and a new modern createNewPage UI client callback
Attachments
Patch (46.01 KB, patch)
2015-08-13 13:58 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-08-13 13:58:51 PDT
Created attachment 258931 [details] Patch
Tim Horton
Comment 2 2015-08-13 14:09:45 PDT
Comment on attachment 258931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258931&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:8 > - * notice, this list of conditions and the following disclaimer. > + * notice, this list of ins and the following disclaimer. NO. > Source/WebKit2/UIProcess/API/C/WKPage.cpp:106 > + typedef std::tuple<WKPageUIClientV0, WKPageUIClientV1, WKPageUIClientV2, WKPageUIClientV3, WKPageUIClientV4, WKPageUIClientV5, WKPageUIClientV6> Versions; ouch
Anders Carlsson
Comment 3 2015-08-13 14:32:00 PDT
Committed r188404: <http://trac.webkit.org/changeset/188404>
WebKit Commit Bot
Comment 4 2015-08-13 21:37:57 PDT
Re-opened since this is blocked by bug 148014
Anders Carlsson
Comment 5 2015-08-17 16:40:10 PDT
Committed r188553: <http://trac.webkit.org/changeset/188553>
Note You need to log in before you can comment on or make changes to this bug.