| Summary: | Separate Qt and libxml based implementations of XMLTokenizer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lars Knoll <lars.knoll> | ||||
| Component: | XML | Assignee: | George Staikos <staikos> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | darin, hausmann | ||||
| Priority: | P2 | Keywords: | Qt | ||||
| Version: | 523.x (Safari 3) | ||||||
| Hardware: | Other | ||||||
| OS: | Other | ||||||
| Attachments: |
|
||||||
|
Description
Lars Knoll
2007-07-27 14:06:14 PDT
Created attachment 15708 [details]
Patch to separate both XMLTokenizer implementations.
Sorry I haven't reviewed this yet. I know I'm the one who asked for it! I'll get to it ASAP (unless someone else reviews it first). No problem. The patch does not fix the fix the build system for the Safari builds btw (as I didn't have a Mac at hand). I was hoping you could add these pieces :) FYI, this patch will conflict with the one attached to bug 15302 (mathml bug, also up for review) Lars, I think we should just chat about this on irc. I've done lots of these types of splits -- they're easy to do, but they tend to go stale as patches *very quickly*. If you grab me (or any other reviewer) on irc, it would be real quick to just re-do this patch from scratch and get it reviewed immediately. I'd be happy to assist in that if I'm around. Comment on attachment 15708 [details]
Patch to separate both XMLTokenizer implementations.
This should be re-done and reviewed immediately. I'm certain this patch has rotten by now. :(
|