Bug 147781

Summary: Reduce uses of PassRefPtr in bindings
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, benjamin, commit-queue, jsbell
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-08-07 05:59:17 PDT
SSIA.
Attachments
Patch (37.33 KB, patch)
2015-08-07 06:00 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (37.38 KB, patch)
2015-08-07 07:34 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (39.35 KB, patch)
2015-08-07 08:02 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (39.40 KB, patch)
2015-08-07 16:18 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-08-07 06:00:50 PDT
Created attachment 258488 [details] Patch
Gyuyoung Kim
Comment 2 2015-08-07 07:34:52 PDT
Created attachment 258496 [details] Patch
Gyuyoung Kim
Comment 3 2015-08-07 08:02:48 PDT
Created attachment 258499 [details] Patch
Gyuyoung Kim
Comment 4 2015-08-07 16:18:11 PDT
Created attachment 258540 [details] Patch
Chris Dumez
Comment 5 2015-08-07 18:44:37 PDT
Comment on attachment 258540 [details] Patch r=me but you need to rebaseline the bindings tests like so: Tools/Scripts/run-bindings-tests --reset-results
Gyuyoung Kim
Comment 6 2015-08-07 21:16:26 PDT
(In reply to comment #5) > Comment on attachment 258540 [details] > Patch > > r=me but you need to rebaseline the bindings tests like so: > Tools/Scripts/run-bindings-tests --reset-results Thank you for review. BTW all tests are passed. So I don't know what tests should be rebaseline.
Chris Dumez
Comment 7 2015-08-07 21:43:38 PDT
Comment on attachment 258540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258540&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:903 > + push(@headerContent, " static RefPtr<NodeFilter> toWrapped(JSC::VM&, JSC::JSValue);\n"); You altered the bindings generator here so I assumed that the bindings tests needed rebaselining. If they don't then it likely means our test coverage isn't good enough.
Gyuyoung Kim
Comment 8 2015-08-07 21:50:04 PDT
Comment on attachment 258540 [details] Patch win-ews seems to be broken now. Let me check win bot after landing this patch.
WebKit Commit Bot
Comment 9 2015-08-07 22:39:23 PDT
Comment on attachment 258540 [details] Patch Clearing flags on attachment: 258540 Committed r188187: <http://trac.webkit.org/changeset/188187>
WebKit Commit Bot
Comment 10 2015-08-07 22:39:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.