Summary: | Reduce uses of PassRefPtr in bindings | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | alecflett, benjamin, commit-queue, jsbell | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 144092 | ||||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-08-07 05:59:17 PDT
Created attachment 258488 [details]
Patch
Created attachment 258496 [details]
Patch
Created attachment 258499 [details]
Patch
Created attachment 258540 [details]
Patch
Comment on attachment 258540 [details]
Patch
r=me but you need to rebaseline the bindings tests like so: Tools/Scripts/run-bindings-tests --reset-results
(In reply to comment #5) > Comment on attachment 258540 [details] > Patch > > r=me but you need to rebaseline the bindings tests like so: > Tools/Scripts/run-bindings-tests --reset-results Thank you for review. BTW all tests are passed. So I don't know what tests should be rebaseline. Comment on attachment 258540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258540&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:903 > + push(@headerContent, " static RefPtr<NodeFilter> toWrapped(JSC::VM&, JSC::JSValue);\n"); You altered the bindings generator here so I assumed that the bindings tests needed rebaselining. If they don't then it likely means our test coverage isn't good enough. Comment on attachment 258540 [details]
Patch
win-ews seems to be broken now. Let me check win bot after landing this patch.
Comment on attachment 258540 [details] Patch Clearing flags on attachment: 258540 Committed r188187: <http://trac.webkit.org/changeset/188187> All reviewed patches have been landed. Closing bug. |