[Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

We started trying to capture build failures into our build log back in 2013, and added special logic for Visual Studio Express because the build driver was not emitting errors to stdout.

However, in Bug 140845 we switched to MSBuild for all builds, which handles this output properly.

Since MSBuild uses BuildOutput.htm directly, the file can be locked by MSBuild activity causing the overall build process to fail due to the 'die' command in the build-webkit Perl script.

We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.

Remove this unneeded (and bug-prone) code to improve the build reliability.

[Brent Fulgham]

Created attachment 258186 [details]
Patch

[Alex Christensen]

Comment on attachment 258186 [details]
Patch

r=me
I was thinking about doing this last week
Do you think this will help with https://bugs.webkit.org/show_bug.cgi?id=146628

[WebKit Commit Bot]

Comment on attachment 258186 [details]
Patch

Clearing flags on attachment: 258186

Committed r187874: <http://trac.webkit.org/changeset/187874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

(In reply to comment #2)
> Comment on attachment 258186 [details]
> Patch
> 
> r=me
> I was thinking about doing this last week
> Do you think this will help with
> https://bugs.webkit.org/show_bug.cgi?id=146628

That's my hope. I'm trying to track down any errors or differences in EWS versus the other builds.