Bug 147457

Summary: Move locale information into FontDescription
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 147430, 149898    
Bug Blocks: 147390, 147483    
Attachments:
Description Flags
Patch
kling: review+
Retry commit-queue: commit-queue-

Description Myles C. Maxfield 2015-07-30 15:02:39 PDT
Move locale information into FontDescription
Comment 1 Myles C. Maxfield 2015-07-30 15:04:02 PDT
Created attachment 257857 [details]
Patch
Comment 2 Andreas Kling 2015-07-30 15:20:41 PDT
Comment on attachment 257857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257857&action=review

r=me

> Source/WebCore/platform/graphics/FontDescription.cpp:68
> +    : m_families(1)
> +    , m_locale(initialLocale())
> +    , m_specifiedSize(0)
> +    , m_computedSize(0)
> +    , m_orientation(Horizontal)
> +    , m_nonCJKGlyphOrientation(NonCJKGlyphOrientationVerticalRight)
> +    , m_widthVariant(RegularWidth)
> +    , m_italic(FontItalicOff)
> +    , m_smallCaps(FontSmallCapsOff)
> +    , m_isAbsoluteSize(false)
> +    , m_weight(FontWeightNormal)
> +    , m_renderingMode(NormalRenderingMode)
> +    , m_kerning(AutoKerning)
> +    , m_commonLigaturesState(NormalLigaturesState)
> +    , m_discretionaryLigaturesState(NormalLigaturesState)
> +    , m_historicalLigaturesState(NormalLigaturesState)
> +    , m_keywordSize(0)
> +    , m_fontSmoothing(AutoSmoothing)
> +    , m_textRendering(AutoTextRendering)
> +    , m_isSpecifiedFont(false)
> +    , m_script(localeToScriptCodeForFontSelection(m_locale))
> +    , m_fontSynthesis(initialFontSynthesis())

Can we move all these initializers to the member declarations instead? ({ })
Comment 3 Myles C. Maxfield 2015-07-30 17:12:48 PDT
Committed r187626: <http://trac.webkit.org/changeset/187626>
Comment 4 Myles C. Maxfield 2015-11-10 17:30:13 PST
Reverted in https://bugs.webkit.org/show_bug.cgi?id=149898
Comment 5 Myles C. Maxfield 2015-11-10 17:32:11 PST
Created attachment 265254 [details]
Retry
Comment 6 WebKit Commit Bot 2015-11-10 18:23:29 PST
Comment on attachment 265254 [details]
Retry

Rejecting attachment 265254 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 265254, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/412577
Comment 7 Myles C. Maxfield 2015-11-10 20:21:35 PST
Committed r192290: <http://trac.webkit.org/changeset/192290>