Bug 147174

Summary: Fix quirks in CMake build on Mac and Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2015-07-21 17:07:05 PDT
https://bugs.webkit.org/show_bug.cgi?id=147169 has a lot of things going on at the same time. It fixes some quirks and switches the WinCairo build to use CMake by default. Let's fix the quirks in a separate patch.
Attachments
Patch (15.50 KB, patch)
2015-07-21 17:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2015-07-21 17:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (13.79 KB, patch)
2015-07-21 17:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.32 KB, patch)
2015-07-21 18:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.35 KB, patch)
2015-07-22 08:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-07-21 17:18:40 PDT
Created attachment 257220 [details] Patch
Alex Christensen
Comment 2 2015-07-21 17:27:42 PDT
Created attachment 257222 [details] Patch
Alex Christensen
Comment 3 2015-07-21 17:58:21 PDT
Created attachment 257227 [details] Patch
Alex Christensen
Comment 4 2015-07-21 18:49:28 PDT
Created attachment 257237 [details] Patch
Gyuyoung Kim
Comment 5 2015-07-21 19:51:41 PDT
Comment on attachment 257237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257237&action=review > Tools/CMakeLists.txt:31 > +#FIXME: Get DumpRenderTree working with CMake. Need indentation ? > Tools/WinLauncher/CMakeLists.txt:51 > +target_link_libraries(WinLauncher shlwapi) Just question. Doesn't *WinLauncher* excutable need to link *WinLauncherLib* ?
Alex Christensen
Comment 6 2015-07-22 08:55:21 PDT
Comment on attachment 257237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257237&action=review >> Tools/CMakeLists.txt:31 >> +#FIXME: Get DumpRenderTree working with CMake. > > Need indentation ? Sure. >> Tools/WinLauncher/CMakeLists.txt:51 >> +target_link_libraries(WinLauncher shlwapi) > > Just question. Doesn't *WinLauncher* excutable need to link *WinLauncherLib* ? It doesn't. DLLLauncherMain.cpp looks for a dll with the same name as the current executable and loads it with LoadLibraryW.
Alex Christensen
Comment 7 2015-07-22 08:58:46 PDT
Created attachment 257276 [details] Patch
Alex Christensen
Comment 8 2015-07-22 09:32:22 PDT
Comment on attachment 257276 [details] Patch win ews failure seems unrelated. cq+ and will check windows build bots in a half hour or so.
Alex Christensen
Comment 9 2015-07-22 10:05:47 PDT
http://trac.webkit.org/changeset/187161
Note You need to log in before you can comment on or make changes to this bug.