| Summary: | Switch WinCairo build to use CMake | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dbates, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2015-07-21 15:55:55 PDT
Created attachment 257213 [details]
Patch
Comment on attachment 257213 [details] Patch I moved most of this to https://bugs.webkit.org/show_bug.cgi?id=147174 I'll do the switch after that lands. Created attachment 257281 [details]
Patch
Comment on attachment 257281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257281&action=review Looks great! r=me, but please correct the spacing on that concatenation operator. > Tools/Scripts/build-webkit:264 > + $result = buildVisualStudioProject("WebKitBuild/".configuration()."/WebKit.sln", $clean); I think you should have spaces around the concatenation operator (.) (In reply to comment #5) > http://trac.webkit.org/changeset/187169 It broke the Apple Windows build. Don't you watch the bots when you land patches? I did not in this case. I should have. Fix committed to http://trac.webkit.org/changeset/187235 |