Bug 146616

Summary: Web Inspector: Mark console filters that have unseen messages by colored dots
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Expected
none
Test page (for manual testing)
none
Patch
none
[Animated GIF] With the patch applied none

Nikita Vasilyev
Reported 2015-07-04 20:47:29 PDT
Created attachment 256168 [details] [Image] Expected "Web Inspector: Console should indicate if you have unseen messages in console due to filters" (https://bugs.webkit.org/show_bug.cgi?id=143166) introduced colored borders. I suggest to replace them with colored dots to make it more esthetically pleasing.
Attachments
[Image] Expected (31.54 KB, image/png)
2015-07-04 20:47 PDT, Nikita Vasilyev 		no flags
Details
Test page (for manual testing) (241 bytes, text/html)
2015-07-06 05:49 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.40 KB, patch)
2015-07-06 05:58 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With the patch applied (1.05 MB, image/gif)
2015-07-06 06:03 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-04 20:47:40 PDT
<rdar://problem/21675741>
Timothy Hatcher
Comment 2 2015-07-04 23:06:49 PDT
I like the dots. Post a patch?
Nikita Vasilyev
Comment 3 2015-07-06 05:49:01 PDT
Created attachment 256209 [details] Test page (for manual testing)
Nikita Vasilyev
Comment 4 2015-07-06 05:58:19 PDT
Created attachment 256211 [details] Patch
Nikita Vasilyev
Comment 5 2015-07-06 06:03:36 PDT
Created attachment 256212 [details] [Animated GIF] With the patch applied
Timothy Hatcher
Comment 6 2015-07-06 07:19:33 PDT
Comment on attachment 256211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256211&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.css:27 > + content: ''; Nit: Double quotes.
WebKit Commit Bot
Comment 7 2015-07-06 08:09:39 PDT
Comment on attachment 256211 [details] Patch Clearing flags on attachment: 256211 Committed r186354: <http://trac.webkit.org/changeset/186354>
WebKit Commit Bot
Comment 8 2015-07-06 08:09:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.