Summary: | Use Ref/RefPtr instead of PassRefPtr in WebKit2 - 2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit2 | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dbates | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 144092 | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-07-03 07:27:51 PDT
Created attachment 256101 [details]
Patch
Created attachment 256140 [details]
Patch
Comment on attachment 256140 [details] Patch Clearing flags on attachment: 256140 Committed r186566: <http://trac.webkit.org/changeset/186566> All reviewed patches have been landed. Closing bug. This introduced a build failure in Windows: ..\..\win\Plugins\PluginView.cpp(855): error C2556: 'WTF::PassRefPtr<T> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' : overloaded function differs only by return type from 'WTF::Ref<WebCore::PluginView> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj] dbates fixed it: <http://trac.webkit.org/changeset/186578> (In reply to comment #6) > dbates fixed it: <http://trac.webkit.org/changeset/186578> Thank you for fixing it. |