Bug 146075 – [EFL] test_ewk2_context_url_scheme_register has been crashed since r185553

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

Since r185553, CustomProtocolManager sends StartLoading with request of SoupGenericRequest instead of request itself. 

But, EFL port does not set m_initiatingPageID via InjectedBundle, so updateSoupRequest did not update request of SoupGenericRequest via webkitSoupRequestGenericSetRequest.

[Ryuan Choi]

Created attachment 255036 [details]
one suggestion

[Carlos Garcia Campos]

Comment on attachment 255036 [details]
one suggestion

View in context: https://bugs.webkit.org/attachment.cgi?id=255036&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-127
> -    if (!m_initiatingPageID)
> -        return;

Ah, sorry, I didn't notice this early return.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:130
> +    if (m_initiatingPageID) {
> +        uint64_t* initiatingPageIDPtr = static_cast<uint64_t*>(fastMalloc(sizeof(uint64_t)));
> +        *initiatingPageIDPtr = m_initiatingPageID;
> +        g_object_set_data_full(G_OBJECT(soupRequest), g_intern_static_string(gSoupRequestInitiatingPageIDKey), initiatingPageIDPtr, fastFree);
> +    }

This correct.

[Ryuan Choi]

Comment on attachment 255036 [details]
one suggestion

Clearing flags on attachment: 255036

Committed r185693: <http://trac.webkit.org/changeset/185693>

[Ryuan Choi]

All reviewed patches have been landed.  Closing bug.