Bug 146046 - [EFL] test_ewk2_context has been failed since r185529
Summary: [EFL] test_ewk2_context has been failed since r185529
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 146075
Blocks: 132813
  Show dependency tree / graph
 
Reported: 2015-06-16 21:36 PDT by Gyuyoung Kim
Modified: 2015-06-18 01:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2015-06-16 22:25 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2015-06-17 22:56 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (2.33 KB, patch)
2015-06-18 01:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-06-16 21:36:44 PDT 
We need to investigate this problem as soon as possible.
Comment 1 Gyuyoung Kim 2015-06-16 22:25:53 PDT 
Created attachment 255000 [details]
Patch
Comment 2 Ryuan Choi 2015-06-17 14:20:28 PDT 
I will cover ewk2_context_scheme_register in Bug 146075
Comment 3 Gyuyoung Kim 2015-06-17 17:23:56 PDT 
(In reply to comment #2)
> I will cover ewk2_context_scheme_register in Bug 146075

Oh, nice ! If your patch is landed first, I won't disable ewk2_context_scheme_register in this patch.
Comment 4 Gyuyoung Kim 2015-06-17 22:56:41 PDT 
Created attachment 255087 [details]
Patch
Comment 5 Gyuyoung Kim 2015-06-17 22:57:48 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > I will cover ewk2_context_scheme_register in Bug 146075
> 
> Oh, nice ! If your patch is landed first, I won't disable
> ewk2_context_scheme_register in this patch.

Bug 146075 got r+ faster than this bug :). I update this patch based on Bug 146075.
Comment 6 Csaba Osztrogonác 2015-06-18 01:03:09 PDT 
Comment on attachment 255087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review

r=me if the test still pass after the typo fix.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216
> +    ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID);

I think you meant webView_2_NetworkProcessID as the second parameter.
Comment 7 Gyuyoung Kim 2015-06-18 01:08:14 PDT 
Created attachment 255099 [details]
Patch for landing
Comment 8 Gyuyoung Kim 2015-06-18 01:09:37 PDT 
Comment on attachment 255087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216
>> +    ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID);
> 
> I think you meant webView_2_NetworkProcessID as the second parameter.

Nice catch ! yes, it should be webView2NetworkProcessID. Test is still passed after using webView2NetworkProcessID.
Comment 9 WebKit Commit Bot 2015-06-18 01:57:52 PDT 
Comment on attachment 255099 [details]
Patch for landing

Clearing flags on attachment: 255099

Committed r185696: <http://trac.webkit.org/changeset/185696>
Comment 10 WebKit Commit Bot 2015-06-18 01:57:59 PDT 
All reviewed patches have been landed.  Closing bug.