Bug 146001

Summary: Purge PassRefPtr with Ref or RefPtr in WebKit2
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Gyuyoung Kim 2015-06-15 19:07:00 PDT 
As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2. If function can't return nullptr, PassRefPtr is changed with Ref. If not, the function returns RefPtr.
Comment 1 Gyuyoung Kim 2015-06-15 19:08:53 PDT 
Created attachment 254920 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-15 19:15:51 PDT 
Created attachment 254922 [details]
Patch
Comment 3 Gyuyoung Kim 2015-06-15 21:56:16 PDT 
Created attachment 254929 [details]
Patch
Comment 4 Gyuyoung Kim 2015-06-15 22:01:25 PDT 
Created attachment 254930 [details]
Patch
Comment 5 Gyuyoung Kim 2015-06-15 22:10:26 PDT 
Created attachment 254932 [details]
Patch
Comment 6 Darin Adler 2015-06-16 10:55:04 PDT 
Comment on attachment 254932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review

> Source/WebKit2/ChangeLog:8
> +        As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2.

This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2.

> Source/WebKit2/Shared/API/APINumber.h:39
> +    static RefPtr<Number> create(NumberType value)

Why RefPtr instead of Ref here?

> Source/WebKit2/Shared/API/APISecurityOrigin.h:50
>              return 0;

nullptr

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4659
> +    callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException);

nullptr
Comment 7 Gyuyoung Kim 2015-06-16 18:56:47 PDT 
Created attachment 254994 [details]
Patch
Comment 8 Gyuyoung Kim 2015-06-16 19:01:30 PDT 
Comment on attachment 254932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review

>> Source/WebKit2/ChangeLog:8
>> +        As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2.
> 
> This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2.

Yes, you are right. I fix this changelog. Let me write changelog in upcoming patch carefully.

>> Source/WebKit2/Shared/API/APINumber.h:39
>> +    static RefPtr<Number> create(NumberType value)
> 
> Why RefPtr instead of Ref here?

done.

>> Source/WebKit2/Shared/API/APISecurityOrigin.h:50
>>              return 0;
> 
> nullptr

done.

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:4659
>> +    callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException);
> 
> nullptr

done.
Comment 9 WebKit Commit Bot 2015-06-16 20:34:07 PDT 
Comment on attachment 254994 [details]
Patch

Clearing flags on attachment: 254994

Committed r185637: <http://trac.webkit.org/changeset/185637>
Comment 10 WebKit Commit Bot 2015-06-16 20:34:12 PDT 
All reviewed patches have been landed.  Closing bug.