Bug 145754

Summary: [ARM] Add the missing setupArgumentsWithExecState functions after r185240
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cgarcia, clopez, commit-queue, ggaren, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 145673    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2015-06-08 03:09:04 PDT
http://trac.webkit.org/changeset/185240 broke the ARM Linux builds
because of missing setupArgumentsWithExecState implementations.

I started work on it, patch is coming soon.
Comment 1 Csaba Osztrogonác 2015-06-08 03:30:32 PDT
Created attachment 254484 [details]
Patch

build already tested, I'll set r? flag when testing is finished.
Comment 2 Csaba Osztrogonác 2015-06-08 05:53:26 PDT
Comment on attachment 254484 [details]
Patch

all tests pass with the patch
Comment 3 Benjamin Poulain 2015-06-08 10:18:40 PDT
Comment on attachment 254484 [details]
Patch

Is this for classic ARM? IIRC, I tried my patch on ARMv7.

Thanks for fixing in any case.
Comment 4 Csaba Osztrogonác 2015-06-08 10:32:30 PDT
(In reply to comment #3)
> Comment on attachment 254484 [details]
> Patch
> 
> Is this for classic ARM? IIRC, I tried my patch on ARMv7.
> 
> Thanks for fixing in any case.

This build issue isn't related to the ARM/Thumb2 instruction set or 
v6/v7 architecture. On Linux we use ARM EABI and we have to align a
64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro
( == TrustedImm32(0) ) is responible for this alignment. But unfortunately
we need more setupArgumentsWithExecState() because of the dummy argument.
Comment 5 WebKit Commit Bot 2015-06-08 11:22:30 PDT
Comment on attachment 254484 [details]
Patch

Clearing flags on attachment: 254484

Committed r185323: <http://trac.webkit.org/changeset/185323>
Comment 6 WebKit Commit Bot 2015-06-08 11:22:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Benjamin Poulain 2015-06-08 13:23:10 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 254484 [details]
> > Patch
> > 
> > Is this for classic ARM? IIRC, I tried my patch on ARMv7.
> > 
> > Thanks for fixing in any case.
> 
> This build issue isn't related to the ARM/Thumb2 instruction set or 
> v6/v7 architecture. On Linux we use ARM EABI and we have to align a
> 64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro
> ( == TrustedImm32(0) ) is responible for this alignment. But unfortunately
> we need more setupArgumentsWithExecState() because of the dummy argument.

Oh, I did not know about that.

I'll try to remember that for next time.