| Summary: | Fix options in build-jsc for CMake builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, gyuyoung.kim | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 145516 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2015-06-03 23:18:09 PDT
Created attachment 254250 [details]
Patch
Comment on attachment 254250 [details] Patch I can't find why did r185110 also modify cmake port on bug 145516. https://bugs.webkit.org/show_bug.cgi?id=145516 AFAIK, cmake port needs to use ON/OFF. If we set nothing, it is set to false. http://www.cmake.org/cmake/help/v3.0/command/option.html Comment on attachment 254250 [details] Patch Clearing flags on attachment: 254250 Committed r185194: <http://trac.webkit.org/changeset/185194> All reviewed patches have been landed. Closing bug. One more thing, if we don't set value for passing arguments, cmake generates build error as below, ~/WebKit$ Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_INDEXED_DATABASE_IN_WORKERS" Not searching for unused variables given on the command line. Parse error in command line argument: -DENABLE_INDEXED_DATABASE_IN_WORKERS Should be: VAR:type=value CMake Error: No cmake script provided. CMake Error: Problem processing arguments. Aborting. |