| Summary: | [EFL] API test has been broken since r184357 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, lucas.de.marchi, mcatanzaro, mrobinson, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 145018 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Gyuyoung Kim
2015-06-03 23:05:48 PDT
Need to check below range. - Begin : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21905 - End : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21921 Oops... EFL API tests work on xvfb.... I find what revision break EFL API test. r184357 did it because suppress build warning related with cmake. https://bugs.webkit.org/show_bug.cgi?id=145018#c0 However it looks TARGET_FILE property isn't supported by cmake 2.8.12 correctly yet. Created attachment 254342 [details]
Patch
CC'ing Michael and Martin, I would like to revert r184357 at the moment. However if you guys know better fix, please let me know. Yes, I think it is fine to revert for the moment. It's better to have test coverage. Yes, go ahead and revert, although I wish we knew what was wrong. I did check to make sure we could use TARGET_FILE with cmake 2.8.12. Comment on attachment 254342 [details] Patch Clearing flags on attachment: 254342 Committed r185281: <http://trac.webkit.org/changeset/185281> All reviewed patches have been landed. Closing bug. |