Bug 145534

Summary:

Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Animated GIF] Actual/expected	none
Patch	timothy: review+, nvasilyev: commit-queue-
[Image] button background bug	none
Patch	none

Nikita Vasilyev

Reported 2015-06-01 16:42:37 PDT

Created attachment 254024 [details] [Animated GIF] Actual/expected Also, when Web Inspector window is inactive, it has a border that looks out of place. via https://bugs.webkit.org/show_bug.cgi?id=144209

Attachments
[Animated GIF] Actual/expected (24.78 KB, image/gif) 2015-06-01 16:42 PDT, Nikita Vasilyev	no flags	Details
Patch (2.03 KB, patch) 2015-06-01 16:50 PDT, Nikita Vasilyev	timothy: review+ nvasilyev: commit-queue-	Details Formatted Diff Diff
[Image] button background bug (3.82 KB, image/png) 2015-06-01 17:37 PDT, Nikita Vasilyev	no flags	Details
Patch (2.07 KB, patch) 2015-06-01 17:44 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-01 16:43:02 PDT

<rdar://problem/21193048>

Nikita Vasilyev

Comment 2 2015-06-01 16:50:56 PDT

Created attachment 254026 [details] Patch Generally, I consider !important as a code-smell. In this case, I think, it’s rather a simple and progmatic solution.

Timothy Hatcher

Comment 3 2015-06-01 16:51:01 PDT

Is there also a bug tracking the overlapping function name and the arrow on the right?

Nikita Vasilyev

Comment 4 2015-06-01 16:54:36 PDT

Not that I know of. I was about to create one.

Nikita Vasilyev

Comment 5 2015-06-01 17:33:43 PDT

Comment on attachment 254026 [details] Patch It looks poor on OS X > 10.10.

Nikita Vasilyev

Comment 6 2015-06-01 17:37:46 PDT

Created attachment 254032 [details] [Image] button background bug

Nikita Vasilyev

Comment 7 2015-06-01 17:44:02 PDT

Created attachment 254034 [details] Patch

WebKit Commit Bot

Comment 8 2015-06-01 18:54:08 PDT

Comment on attachment 254034 [details] Patch Clearing flags on attachment: 254034 Committed r185094: <http://trac.webkit.org/changeset/185094>

WebKit Commit Bot

Comment 9 2015-06-01 18:54:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.