Summary: | Make the type profiler work with lexical scoping and add tests | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | basile_clement, buildbot, burg, commit-queue, fpizlo, ggaren, joepeck, mark.lam, mmirman, msaboff, oliver, rniwa, timothy | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Bug Depends on: | 142944 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Saam Barati
2015-05-28 09:11:50 PDT
*** Bug 145958 has been marked as a duplicate of this bug. *** Created attachment 257298 [details]
patch
Attachment 257298 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:3276: Missing space after , [whitespace/comma] [3]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 257298 [details] patch Attachment 257298 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4857734449070080 New failing tests: js/arguments-iterator.html js/basic-strict-mode.html Created attachment 257301 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 257298 [details] patch Attachment 257298 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4972823466475520 New failing tests: js/arguments-iterator.html js/basic-strict-mode.html Created attachment 257302 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 257656 [details]
patch
Comment on attachment 257656 [details] patch Attachment 257656 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4768745276833792 New failing tests: js/arguments-iterator.html js/basic-strict-mode.html Created attachment 257663 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 257656 [details] patch Attachment 257656 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5050220253544448 New failing tests: js/arguments-iterator.html js/basic-strict-mode.html Created attachment 257665 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 257668 [details]
patch
Lets not remove a needed early return :)
Comment on attachment 257668 [details]
patch
r=me
Fixing 32-bit build locally then will commit. landed in: http://trac.webkit.org/changeset/187524 |