Bug 145211

Summary: [GTK] Bump GCC requirements to 4.9.0
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, mcatanzaro, mrobinson, ossy, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98932    
Attachments:
Description Flags
Patch
none
Patch zan: review+

Carlos Garcia Campos
Reported 2015-05-20 08:57:09 PDT
It's required to build with IndexedDB support when using GCC, clang works just fine. All the bots have already been upgraded.
Attachments
Patch (1.48 KB, patch)
2015-05-20 08:58 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2015-05-20 09:29 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-05-20 08:58:43 PDT
Created attachment 253440 [details] Patch
Zan Dobersek
Comment 2 2015-05-20 09:29:04 PDT
EWS machines apparently haven't been updated.
Carlos Garcia Campos
Comment 3 2015-05-20 09:29:30 PDT
Created attachment 253441 [details] Patch
Carlos Garcia Campos
Comment 4 2015-05-20 09:32:49 PDT
(In reply to comment #2) > EWS machines apparently haven't been updated. They were, see green boxes in bug #98932, but I think CMake stupid cache still had the old compiler version somewhere.
Zan Dobersek
Comment 5 2015-05-20 09:42:29 PDT
Comment on attachment 253441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253441&action=review > Source/cmake/OptionsGTK.cmake:10 > +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932. GCC*.
Carlos Garcia Campos
Comment 6 2015-05-20 09:45:53 PDT
(In reply to comment #5) > Comment on attachment 253441 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253441&action=review > > > Source/cmake/OptionsGTK.cmake:10 > > +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932. > > GCC*. Oops. Thanks for the review, I'll wait for EWS anyway, and even more important for Martin's approval since he was not convinced yet to bump requirements.
Carlos Garcia Campos
Comment 7 2015-05-21 23:07:17 PDT
Martin?
Martin Robinson
Comment 8 2015-05-22 15:39:42 PDT
(In reply to comment #7) > Martin? It seems pretty simple to make the build conditional. If we need to do that we can go back and do it later, so I'm not going to block this. :)
Carlos Garcia Campos
Comment 9 2015-05-24 23:55:21 PDT
Committed r184849: <http://trac.webkit.org/changeset/184849>
Note You need to log in before you can comment on or make changes to this bug.