Bug 144904

Summary: Return Ref instead of PassRefPtr in create() factory functions of WebCore/dom
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2015-05-12 00:12:51 PDT
We return Ref when we're sure if pointer can't be null. If not, we use RefPtr instead PassRefPtr.
Attachments
Patch (23.23 KB, patch)
2015-05-12 00:14 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-05-12 00:14:38 PDT
Created attachment 252947 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-12 17:31:56 PDT
Comment on attachment 252947 [details] Patch Clearing flags on attachment: 252947 Committed r184225: <http://trac.webkit.org/changeset/184225>
WebKit Commit Bot
Comment 3 2015-05-12 17:31:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.