Bug 144904

Summary:

Return Ref instead of PassRefPtr in create() factory functions of WebCore/dom

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Gyuyoung Kim 2015-05-12 00:12:51 PDT

We return Ref when we're sure if pointer can't be null. If not, we use RefPtr instead PassRefPtr.

Comment 1 Gyuyoung Kim 2015-05-12 00:14:38 PDT

Created attachment 252947 [details]
Patch

Comment 2 WebKit Commit Bot 2015-05-12 17:31:56 PDT

Comment on attachment 252947 [details]
Patch

Clearing flags on attachment: 252947

Committed r184225: <http://trac.webkit.org/changeset/184225>

Comment 3 WebKit Commit Bot 2015-05-12 17:31:59 PDT

All reviewed patches have been landed.  Closing bug.