Bug 144904 - Return Ref instead of PassRefPtr in create() factory functions of WebCore/dom
Summary: Return Ref instead of PassRefPtr in create() factory functions of WebCore/dom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-05-12 00:12 PDT by Gyuyoung Kim
Modified: 2015-05-12 17:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (23.23 KB, patch)
2015-05-12 00:14 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-05-12 00:12:51 PDT 
We return Ref when we're sure if pointer can't be null. If not, we use RefPtr instead PassRefPtr.
Comment 1 Gyuyoung Kim 2015-05-12 00:14:38 PDT 
Created attachment 252947 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-12 17:31:56 PDT 
Comment on attachment 252947 [details]
Patch

Clearing flags on attachment: 252947

Committed r184225: <http://trac.webkit.org/changeset/184225>
Comment 3 WebKit Commit Bot 2015-05-12 17:31:59 PDT 
All reviewed patches have been landed.  Closing bug.