Bug 144873

Summary: Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Layout and RenderingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, hyatt, kangil.han, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 142544    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-05-11 10:56:22 PDT 
Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate():
bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && !isVertical);
->
bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && isVertical);
Comment 1 Chris Dumez 2015-05-11 11:01:18 PDT 
Created attachment 252868 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-05-11 11:12:28 PDT 
Comment on attachment 252868 [details]
Patch

Did any test detect this?
Comment 3 Chris Dumez 2015-05-11 11:13:46 PDT 
(In reply to comment #2)
> Comment on attachment 252868 [details]
> Patch
> 
> Did any test detect this?

Not that I am aware of, it merely stood out when I was reviewing this code.
Comment 4 WebKit Commit Bot 2015-05-11 12:02:52 PDT 
Comment on attachment 252868 [details]
Patch

Clearing flags on attachment: 252868

Committed r184114: <http://trac.webkit.org/changeset/184114>
Comment 5 WebKit Commit Bot 2015-05-11 12:02:59 PDT 
All reviewed patches have been landed.  Closing bug.