Bug 144872

Summary: Purge PassRefPtr in WebCore/rendering
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Description Gyuyoung Kim 2015-05-11 09:06:19 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-05-11 09:07:13 PDT 
Created attachment 252861 [details]
Patch
Comment 2 Gyuyoung Kim 2015-05-11 16:29:18 PDT 
Created attachment 252906 [details]
Patch
Comment 3 Gyuyoung Kim 2015-05-11 17:22:50 PDT 
Created attachment 252911 [details]
Patch
Comment 4 Darin Adler 2015-05-11 18:17:38 PDT 
Comment on attachment 252911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252911&action=review

> Source/WebCore/rendering/RenderThemeSafari.cpp:91
> +        return &windowsTheme; // keep the reference of one.

I don’t understand the comment “keep the reference of one”.

> Source/WebCore/rendering/RenderThemeSafari.cpp:93
> +    return &safariTheme; // keep the reference of one.

I don’t understand the comment “keep the reference of one”.
Comment 5 Gyuyoung Kim 2015-05-11 19:08:23 PDT 
Committed r184147: <http://trac.webkit.org/changeset/184147>
Comment 6 Gyuyoung Kim 2015-05-11 19:09:49 PDT 
(In reply to comment #4)

> I don’t understand the comment “keep the reference of one”.
> 
> > Source/WebCore/rendering/RenderThemeSafari.cpp:93
> > +    return &safariTheme; // keep the reference of one.
> 
> I don’t understand the comment “keep the reference of one”.

Landed after removing the unneeded comments.