Bug 144516

Summary: Generated static StringImpls should have static flag set.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Template FrameworkAssignee: Andreas Kling <kling>
Status: REOPENED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 144534    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-05-02 00:54:42 PDT
Looks like strings generated by StaticString.pm don't actually get the static flag set on them.
Attachments
Patch (1.45 KB, patch)
2015-05-02 00:55 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-02 00:55:17 PDT
Created attachment 252222 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-02 13:57:16 PDT
Comment on attachment 252222 [details] Patch Clearing flags on attachment: 252222 Committed r183722: <http://trac.webkit.org/changeset/183722>
WebKit Commit Bot
Comment 3 2015-05-02 13:57:22 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2015-05-02 15:54:21 PDT
This made all the tests assert: https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r183722%20(12448)/results.html
WebKit Commit Bot
Comment 5 2015-05-02 15:58:09 PDT
Re-opened since this is blocked by bug 144534
Note You need to log in before you can comment on or make changes to this bug.