Bug 144516 - Generated static StringImpls should have static flag set.
Summary: Generated static StringImpls should have static flag set.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: Performance
Depends on: 144534
  Show dependency treegraph
Reported: 2015-05-02 00:54 PDT by Andreas Kling
Modified: 2015-05-02 15:58 PDT (History)
3 users (show)

See Also:

Patch (1.45 KB, patch)
2015-05-02 00:55 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-02 00:54:42 PDT
Looks like strings generated by StaticString.pm don't actually get the static flag set on them.
Comment 1 Andreas Kling 2015-05-02 00:55:17 PDT
Created attachment 252222 [details]
Comment 2 WebKit Commit Bot 2015-05-02 13:57:16 PDT
Comment on attachment 252222 [details]

Clearing flags on attachment: 252222

Committed r183722: <http://trac.webkit.org/changeset/183722>
Comment 3 WebKit Commit Bot 2015-05-02 13:57:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2015-05-02 15:54:21 PDT
This made all the tests assert: https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r183722%20(12448)/results.html
Comment 5 WebKit Commit Bot 2015-05-02 15:58:09 PDT
Re-opened since this is blocked by bug 144534