Bug 144398

Summary:

Evict IsEnvironmentRecord from inline type flags

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

144397

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2015-04-29 10:21:32 PDT

It's not important enough to be inline. This will make room for more important things.

Comment 1 Filip Pizlo 2015-04-29 10:25:54 PDT

Created attachment 251965 [details]
the patch

Comment 2 Mark Lam 2015-04-29 10:30:38 PDT

Comment on attachment 251965 [details]
the patch

r=me

Comment 3 Michael Saboff 2015-04-29 10:31:36 PDT

Comment on attachment 251965 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251965&action=review

r=me with nit.

> Source/JavaScriptCore/ChangeLog:9
> +        type flags. This change picks the least important inline time flag - IsEnvironmentRecord -

nit - should this say - "... important inline *type* flag."?

Comment 4 Filip Pizlo 2015-04-29 10:40:03 PDT

Landed in http://trac.webkit.org/changeset/183557