144397 – JSTypeInfo should have an inline type flag to indicate if getCallData() has been overridden

Bug 144397 - JSTypeInfo should have an inline type flag to indicate if getCallData() has been overridden

Summary: JSTypeInfo should have an inline type flag to indicate if getCallData() has b...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Filip Pizlo

URL:
Keywords:

Depends on:	144398
Blocks:	144396
	Show dependency tree / graph

Attachments
the patch (13.13 KB, patch) 2015-04-29 11:32 PDT, Filip Pizlo	kling: review+	Details \| Formatted Diff \| Diff
hopefully builds this time (13.13 KB, patch) 2015-04-29 13:47 PDT, Filip Pizlo	fpizlo: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Filip Pizlo 2015-04-29 10:17:49 PDT

This will allow TypeOf to skip the getCallData() step for common object types.

Comment 1 Filip Pizlo 2015-04-29 11:32:11 PDT

Created attachment 251972 [details]
the patch

Comment 2 Filip Pizlo 2015-04-29 11:38:40 PDT

I'll let this patch fester on EWS for a bit.

Comment 3 Filip Pizlo 2015-04-29 13:47:52 PDT

Created attachment 251986 [details]
hopefully builds this time

Comment 4 Filip Pizlo 2015-04-29 13:51:33 PDT

Comment on attachment 251986 [details]
hopefully builds this time

R=kling.

Comment 5 Filip Pizlo 2015-04-29 14:29:23 PDT

Landed in http://trac.webkit.org/changeset/183575