Bug 144398 - Evict IsEnvironmentRecord from inline type flags
Summary: Evict IsEnvironmentRecord from inline type flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 144397
  Show dependency tree / graph
 
Reported: 2015-04-29 10:21 PDT by Filip Pizlo
Modified: 2015-04-29 10:40 PDT (History)
11 users (show)

See Also:

Attachments
the patch (4.21 KB, patch)
2015-04-29 10:25 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-29 10:21:32 PDT 
It's not important enough to be inline. This will make room for more important things.
Comment 1 Filip Pizlo 2015-04-29 10:25:54 PDT 
Created attachment 251965 [details]
the patch
Comment 2 Mark Lam 2015-04-29 10:30:38 PDT 
Comment on attachment 251965 [details]
the patch

r=me
Comment 3 Michael Saboff 2015-04-29 10:31:36 PDT 
Comment on attachment 251965 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251965&action=review

r=me with nit.

> Source/JavaScriptCore/ChangeLog:9
> +        type flags. This change picks the least important inline time flag - IsEnvironmentRecord -

nit - should this say - "... important inline *type* flag."?
Comment 4 Filip Pizlo 2015-04-29 10:40:03 PDT 
Landed in http://trac.webkit.org/changeset/183557