Bug 144397

Summary: JSTypeInfo should have an inline type flag to indicate if getCallData() has been overridden
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 144398    
Bug Blocks: 144396    
Attachments:
Description Flags
the patch
kling: review+
hopefully builds this time fpizlo: review+

Filip Pizlo
Reported 2015-04-29 10:17:49 PDT
This will allow TypeOf to skip the getCallData() step for common object types.
Attachments
the patch (13.13 KB, patch)
2015-04-29 11:32 PDT, Filip Pizlo 		kling: review+
DetailsFormatted DiffDiff
hopefully builds this time (13.13 KB, patch)
2015-04-29 13:47 PDT, Filip Pizlo 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-04-29 11:32:11 PDT
Created attachment 251972 [details] the patch
Filip Pizlo
Comment 2 2015-04-29 11:38:40 PDT
I'll let this patch fester on EWS for a bit.
Filip Pizlo
Comment 3 2015-04-29 13:47:52 PDT
Created attachment 251986 [details] hopefully builds this time
Filip Pizlo
Comment 4 2015-04-29 13:51:33 PDT
Comment on attachment 251986 [details] hopefully builds this time R=kling.
Filip Pizlo
Comment 5 2015-04-29 14:29:23 PDT
Landed in http://trac.webkit.org/changeset/183575
Note You need to log in before you can comment on or make changes to this bug.