| Summary: | Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | andersca, buildbot, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 128007 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Darin Adler
2015-04-20 09:11:38 PDT
Created attachment 251161 [details]
Patch
Created attachment 251164 [details]
Patch
Comment on attachment 251164 [details] Patch Attachment 251164 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4713467760082944 Number of test failures exceeded the failure limit. Created attachment 251169 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 251164 [details] Patch Attachment 251164 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4815801999687680 Number of test failures exceeded the failure limit. Created attachment 251180 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 251398 [details]
Patch
The new patch includes fixes for the test failures. Comment on attachment 251398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251398&action=review r=me > Source/WebCore/platform/graphics/FontCascade.cpp:438 > +std::unique_ptr<TextLayout, void (*)(TextLayout*)> FontCascade::createLayout(RenderText&, float, bool) const > { > + return std::unique_ptr<TextLayout, void (*)(TextLayout*)>(nullptr, [](TextLayout*) { }); > } Oh wow, you were not kidding about this monstrosity. (In reply to comment #9) > Oh wow, you were not kidding about this monstrosity. I found a better way to write this after thinking about some suggestions from Anders. I’ll land it after I double check it compiles. Committed r183169: <http://trac.webkit.org/changeset/183169> |