Summary: | Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2 | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||||
Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | ||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||
OS: | All | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 128007 | ||||||||||||||||||||
Attachments: |
|
Description
Darin Adler
2015-04-19 22:52:23 PDT
Created attachment 251144 [details]
Patch
Created attachment 251146 [details]
Patch
Created attachment 251162 [details]
Patch
Comment on attachment 251162 [details]
Patch
Need to fix iOS compilation.
Created attachment 251230 [details]
Patch
Created attachment 251231 [details]
Patch
Comment on attachment 251231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251231&action=review iOS build needs fixing, Editor::insertDictationPhrases needs to be updated. > Source/WebCore/platform/network/ios/QuickLook.mm:191 > +NSURLRequest *WebCore::registerQLPreviewConverterIfNeeded(NSURL *url, NSString *mimeType, NSData *data) I think this should return a RetainPtr instead. Comment on attachment 251231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251231&action=review >> Source/WebCore/platform/network/ios/QuickLook.mm:191 >> +NSURLRequest *WebCore::registerQLPreviewConverterIfNeeded(NSURL *url, NSString *mimeType, NSData *data) > > I think this should return a RetainPtr instead. I see your point. I thought it would just return an autoreleased object, but I guess there’s no guarantee that the result of [converter previewRequest] will still be valid once converter is released. Created attachment 251403 [details]
Patch
Created attachment 251407 [details]
Patch
Created attachment 251408 [details]
Patch
Committed r183172: <http://trac.webkit.org/changeset/183172> |