Bug 143670 – [EFL] fix efreet error

• Component: WebKit EFL
• Status: RESOLVED FIXED

[KwangHyuk]

ERR<25282>:efreet_cache lib/efreet/efreet_cache.c:1134 on_send_register() org.freedesktop.DBus.Error.ServiceUnknown The name org.enlightenment.Efreet was not provided by any .service files

[KwangHyuk]

Created attachment 250646 [details]
Patch

[Csaba Osztrogonác]

Is this bug same as bug134023? It would be good to fix it once. 
This undocumented "feature" is so annoying that the user have 
to add symlinks as root user manually to have a working EFL WebKit. :-/

I tried to get answer for this bug, bug noone answered ever. :(

[Csaba Osztrogonác]

So could you describe me what is this efreet_cache_update magic variable?
And why do we need magic symlinks if it isn't set and why don't we need
if it is set. This changelog doesn't say anything about why is this fix good.

[KwangHyuk]

(In reply to comment #3)
> So could you describe me what is this efreet_cache_update magic variable?
> And why do we need magic symlinks if it isn't set and why don't we need
> if it is set. This changelog doesn't say anything about why is this fix good.

It will not monitor icon and desktop cache basically.
however, in the webkit there is no listener for those caches AFAIK.

[KwangHyuk]

Created attachment 253331 [details]
Patch

[Ryuan Choi]

Comment on attachment 253331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253331&action=review

> Tools/ChangeLog:10
> +        Fix efreet error by using external variable efreet_cache_update.
> +        As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
> +        efreet error for efreet_cache does not occur.

Although I am not familiar with efreet_cache_update, 
I think that it looks workaround not to monitor efreet because elm_file_chooser uses efreet for the icon.
(MiniBrowser uses elm_file_chooser to download and open dialog for input[type=file])

Could you check whether these usages are fine with your patch?

[KwangHyuk]

(In reply to comment #6)
> Comment on attachment 253331 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253331&action=review
> 
> > Tools/ChangeLog:10
> > +        Fix efreet error by using external variable efreet_cache_update.
> > +        As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
> > +        efreet error for efreet_cache does not occur.
> 
> Although I am not familiar with efreet_cache_update, 
> I think that it looks workaround not to monitor efreet because
> elm_file_chooser uses efreet for the icon.
> (MiniBrowser uses elm_file_chooser to download and open dialog for
> input[type=file])
> 
> Could you check whether these usages are fine with your patch?

I checked that file chooser is working without any issue or error messages. :)

[Gyuyoung Kim]

Comment on attachment 253331 [details]
Patch

I don't know why EFL application should set "efree_cache_update" though, I feel I need to do rubber stamp. rs=me.

[WebKit Commit Bot]

Comment on attachment 253331 [details]
Patch

Clearing flags on attachment: 253331

Committed r184691: <http://trac.webkit.org/changeset/184691>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.