Summary: | REGRESSION(181977): It broke the build on the WinCairo bot | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, dbates, mmaxfield, ossy, peavo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 143040 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-03-26 01:07:34 PDT
It seems https://trac.webkit.org/changeset/181977 is the culprit. Alex, can the WinCairo bot be updated to include the Zip Perl package? I installed the zip perl package with this command: setup-x86.exe -q -P perl-Archive-Zip Now it fails with a different error: Can't load '/usr/lib/perl5/5.14/i686-cygwin-threads-64int/auto/IO/IO.dll' for module IO: No such process at /usr/lib/perl5/5.14/XSLoader.pm line 71. at /usr/lib/perl5/5.14/i686-cygwin-threads-64int/IO.pm line 11 /usr/lib/perl5/5.14/i686-cygwin-threads-64int/auto/IO/IO.dll exists in cygwin. What is going on? Installing perl-Archive-Zip on Cygwin killed my perl installation somehow. I installed ActivePerl, and I think with this an Myles' work we could get that working. Created attachment 249549 [details]
Patch
This gets it to build WTF. I see these errors after this patch. Creating library C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitBuild\ Release_WinCairo\lib32\WTF.lib and object C:\cygwin\home\webkitbot\win-cairo-releas e\build\WebKitBuild\Release_WinCairo\lib32\WTF.exp WTF.vcxproj -> C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitBuild\Relea se_WinCairo\bin32\WTF.dll No C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitLibraries\win\tools\Ver sionStamper\VersionStamper.exe executable. Exiting. /usr/bin/bash The system cannot find the path specified. Failed to build C:\cygwin\home\webkitbot\win-cairo-release\build\Source\JavaScrip tCore\DerivedSources.make: No such file or directory at build-generated-files.pl li ne 78. NMAKE : fatal error U1077: 'perl' : return code '0x2' [C:\cygwin\home\webkitbot\win -cairo-release\build\Source\JavaScriptCore\JavaScriptCore.vcxproj\JavaScriptCoreGen erated.vcxproj] Stop. (In reply to comment #6) > This gets it to build WTF. I see these errors after this patch. > > Creating library > C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitBuild\ > Release_WinCairo\lib32\WTF.lib and object > C:\cygwin\home\webkitbot\win-cairo-releas > e\build\WebKitBuild\Release_WinCairo\lib32\WTF.exp > WTF.vcxproj -> > C:\cygwin\home\webkitbot\win-cairo-release\build\WebKitBuild\Relea > se_WinCairo\bin32\WTF.dll > No > C:\cygwin\home\webkitbot\win-cairo- > release\build\WebKitLibraries\win\tools\Ver > sionStamper\VersionStamper.exe executable. Exiting. > /usr/bin/bash > The system cannot find the path specified. > Failed to build > C:\cygwin\home\webkitbot\win-cairo-release\build\Source\JavaScrip > tCore\DerivedSources.make: No such file or directory at > build-generated-files.pl li ne 78. > NMAKE : fatal error U1077: 'perl' : return code '0x2' > [C:\cygwin\home\webkitbot\win > -cairo-release\build\Source\JavaScriptCore\JavaScriptCore. > vcxproj\JavaScriptCoreGen erated.vcxproj] > Stop. I get the VersionStamper error too, but it seems to be benign. Note that the next error you see is from JavaScriptCore, not WTF. Looks fine to me but I'll wait for Brent to give the final go-ahead. Comment on attachment 249549 [details]
Patch
Looks good. I was just waiting for EWS to finish running on it.
Comment on attachment 249549 [details] Patch Clearing flags on attachment: 249549 Committed r182065: <http://trac.webkit.org/changeset/182065> All reviewed patches have been landed. Closing bug. (In reply to comment #10) > Comment on attachment 249549 [details] > Patch > > Clearing flags on attachment: 249549 > > Committed r182065: <http://trac.webkit.org/changeset/182065> The build is still broken: mkdir File::.: Invalid argument; The filename, directory name, or volume label syntax is incorrect at C:/cygwin/home/webkitbot/win-cairo-release/build/Tools/Scripts/webkitdirs.pm line 1678. There are also some problems with cygwin's make using /usr/bin/perl because of headers in files like create_hash_table. I'm taking the bot offline and I plan to fix it next week after Myles finishes patches like https://bugs.webkit.org/show_bug.cgi?id=143084 (In reply to comment #12) > (In reply to comment #10) > > Comment on attachment 249549 [details] > > Patch > > > > Clearing flags on attachment: 249549 > > > > Committed r182065: <http://trac.webkit.org/changeset/182065> > > The build is still broken: > > mkdir File::.: Invalid argument; The filename, directory name, or volume > label syntax is incorrect at > C:/cygwin/home/webkitbot/win-cairo-release/build/Tools/Scripts/webkitdirs.pm > line 1678. I believe https://bugs.webkit.org/show_bug.cgi?id=143084 fixes this. |