Bug 142888

Summary: REGRESSION (r181358): nicescroll.js main-frame scrolling override is broken
Product: WebKit Reporter: Tim Horton <thorton>
Component: DOMAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, bdakin, darin, jimoase, jonlee, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2015-03-19 18:03:38 PDT
Steps to Reproduce: 1. Load http://areaaperta.com/nicescroll/ 2. Scroll horizontally on the page. Expected: Horizontal scrolling should be converted to vertical scrolling. And, scrolling the main frame should feel bizarre (wrong acceleration). Actual: Horizontal scrolling rubber-bands and/or swipes. Scrolling feels normal. Notes: This regressed in http://trac.webkit.org/changeset/181358.
Attachments
Patch (98.45 KB, patch)
2015-03-26 16:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (104.97 KB, patch)
2015-03-26 17:15 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-03-19 18:04:40 PDT
<rdar://problem/20233465>
Darin Adler
Comment 2 2015-03-20 09:37:39 PDT
Ouch! If this was closer to the time I made the change I would say "just roll out". We’ll need to reduce this to a smaller test case to see what caused it. I can’t work on that until tonight. Is there someone who wants to start tracking it down?
Tim Horton
Comment 3 2015-03-26 13:17:54 PDT
The root cause is that ("ontouchstart" in window) is true now, and was false before.
Tim Horton
Comment 4 2015-03-26 13:19:25 PDT
People are using that for feature detection... but it looks like the patch intentionally changed it?
Tim Horton
Comment 5 2015-03-26 14:20:48 PDT
Also affects apple.com/watch
Tim Horton
Comment 6 2015-03-26 15:41:22 PDT
*** Bug 143054 has been marked as a duplicate of this bug. ***
Tim Horton
Comment 7 2015-03-26 16:45:35 PDT
Created attachment 249542 [details] Patch
Beth Dakin
Comment 8 2015-03-26 16:51:40 PDT
Comment on attachment 249542 [details] Patch I think that there are platform-specific results for at least one of those layout tests in both mavericks and win that you will need to update.
Tim Horton
Comment 9 2015-03-26 17:15:26 PDT
Created attachment 249544 [details] Patch
Tim Horton
Comment 10 2015-03-26 18:03:36 PDT
http://trac.webkit.org/changeset/182046
Lucas Forschler
Comment 11 2019-02-06 09:19:00 PST
Mass move bugs into the DOM component.
Note You need to log in before you can comment on or make changes to this bug.