Bug 142473

Summary: [CMake] Enable WorkQueue tests for CMake ports
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142447, 142493    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2015-03-08 21:49:19 PDT
WorkQueue tests exist, but we simply are not compiling them yet.
Attachments
Patch (1.21 KB, patch)
2015-03-08 21:53 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2015-03-09 11:02 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2015-03-08 21:53:40 PDT
Created attachment 248229 [details] Patch
Darin Adler
Comment 2 2015-03-09 00:10:31 PDT
Comment on attachment 248229 [details] Patch Looks like this doesn’t compile on EFL. We should fix that before making this change.
Martin Robinson
Comment 3 2015-03-09 07:34:38 PDT
It seems that the issue is that WorkQueue moved to WTF, but a WorkQeueue dependency for EFL, DispatchQueue, is still part of WebKit2.
Csaba Osztrogonác
Comment 4 2015-03-09 09:34:54 PDT
${WTF_DIR}/wtf/efl should be added to the list of the include directories in Tools/TestWebKitAPI/PlatformEfl.cmake to fix the EFL build. (after bug142493)
Martin Robinson
Comment 5 2015-03-09 11:02:38 PDT
Created attachment 248259 [details] Patch
WebKit Commit Bot
Comment 6 2015-03-09 12:02:51 PDT
Comment on attachment 248259 [details] Patch Clearing flags on attachment: 248259 Committed r181275: <http://trac.webkit.org/changeset/181275>
WebKit Commit Bot
Comment 7 2015-03-09 12:02:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.