| Summary: | [cmake] Handle unused parameter warnings as build errors except in WebKit2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, gyuyoung.kim, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 142497 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Csaba Osztrogonác
2015-03-05 06:10:11 PST
Created attachment 247948 [details]
Patch
webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2015-March/027269.html (In reply to comment #0) > To match the actual Mac settings, we should handle unused parameter warnings > as build build errors, except in WebKit2. In WebKit2, we should simply > suppress them, because Mac port does the same, there is no reason to > newly introduced unused parameter warnings in WebKit2 again and again. typo: ... no reason to _fix_ newly ... Comment on attachment 247948 [details]
Patch
Nobody replied this mail thread. So let's omit to make sound of unused param warning in WebKit2 as Mac port.
Created attachment 248267 [details]
Patch
patch for landing, last EWS check to make sure we won't break the build.
Comment on attachment 248267 [details] Patch Clearing flags on attachment: 248267 Committed r181318: <http://trac.webkit.org/changeset/181318> All reviewed patches have been landed. Closing bug. |