Bug 142330

Summary:

Rename MediaStreamSource to RealtimeMediaSource

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adam.bergkvist, commit-queue, eric.carlson, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

143211

Attachments:

Description	Flags
patch	darin: review-
patch	eric.carlson: review+

Philippe Normand

Reported 2015-03-05 01:43:01 PST

MediaStreamSource is a misleading name, it's not the source of a MediaStream. The chain from high level to low level is: MediaStream - MediaStreamTrack - MediaStreamTrackPrivate - RealTimeMediaSource and a MediaStream can contains several MediaStreamTrack objects of different types.

Attachments
patch (105.84 KB, patch) 2015-03-05 08:39 PST, Philippe Normand	darin: review-	Details Formatted Diff Diff
patch (123.99 KB, patch) 2015-03-06 00:25 PST, Philippe Normand	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2015-03-05 08:39:19 PST

Created attachment 247953 [details] patch

WebKit Commit Bot

Comment 2 2015-03-05 08:42:09 PST

Attachment 247953 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/mediastream/MediaStream.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVAudioCaptureSource.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mock/MockMediaStreamCenter.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceStates.cpp:35: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:37: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/Modules/mediastream/UserMediaRequest.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/mediastream/MediaStreamTrack.h:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 11 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 3 2015-03-05 09:19:57 PST

You need to modify the names in the Xcode project.

Philippe Normand

Comment 4 2015-03-05 10:01:26 PST

Right, I'll take care of this and other code style issues as well :)

Darin Adler

Comment 5 2015-03-05 19:55:10 PST

Comment on attachment 247953 [details] patch Looks like you missed something, which is why the build is failing. I suggest doing this rename with the do-webcore-rename script.

Philippe Normand

Comment 6 2015-03-06 00:25:14 PST

Created attachment 248050 [details] patch

Philippe Normand

Comment 7 2015-03-06 06:08:25 PST

Committed r181152: <http://trac.webkit.org/changeset/181152>

Note You need to log in before you can comment on or make changes to this bug.