Bug 142330 - Rename MediaStreamSource to RealtimeMediaSource
Summary: Rename MediaStreamSource to RealtimeMediaSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency tree / graph
 
Reported: 2015-03-05 01:43 PST by Philippe Normand
Modified: 2015-03-29 23:47 PDT (History)
4 users (show)

See Also:

Attachments
patch (105.84 KB, patch)
2015-03-05 08:39 PST, Philippe Normand 		darin: review-
Details | Formatted Diff | Diff
patch (123.99 KB, patch)
2015-03-06 00:25 PST, Philippe Normand 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-03-05 01:43:01 PST 
MediaStreamSource is a misleading name, it's not the source of a MediaStream.

The chain from high level to low level is: MediaStream - MediaStreamTrack - MediaStreamTrackPrivate - RealTimeMediaSource
and a MediaStream can contains several MediaStreamTrack objects of different types.
Comment 1 Philippe Normand 2015-03-05 08:39:19 PST 
Created attachment 247953 [details]
patch
Comment 2 WebKit Commit Bot 2015-03-05 08:42:09 PST 
Attachment 247953 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaStream.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVAudioCaptureSource.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockMediaStreamCenter.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceStates.cpp:35:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:37:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/UserMediaRequest.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaStreamTrack.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 11 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2015-03-05 09:19:57 PST 
You need to modify the names in the Xcode project.
Comment 4 Philippe Normand 2015-03-05 10:01:26 PST 
Right, I'll take care of this and other code style issues as well :)
Comment 5 Darin Adler 2015-03-05 19:55:10 PST 
Comment on attachment 247953 [details]
patch

Looks like you missed something, which is why the build is failing. I suggest doing this rename with the do-webcore-rename script.
Comment 6 Philippe Normand 2015-03-06 00:25:14 PST 
Created attachment 248050 [details]
patch
Comment 7 Philippe Normand 2015-03-06 06:08:25 PST 
Committed r181152: <http://trac.webkit.org/changeset/181152>