Summary: | [Win] [Attachment] New Tests fail on Windows | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, sam, thorton |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | All | ||
Bug Depends on: | 141993 | ||
Bug Blocks: |
Description
Brent Fulgham
2015-02-25 09:33:18 PST
Failing test skipped on Windows in r180629. <https://trac.webkit.org/r180629> Committed r180990: <http://trac.webkit.org/changeset/180990> This needed two things: 1. Activate the feature on Windows. 2. Update baselines for Windows display metrics. This broke Windows build: 1>C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error C2065: 'CSSValueAttachment' : undeclared identifier (C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder.cpp) (In reply to comment #4) > This broke Windows build: > > > 1>C:\cygwin\home\buildbot\slave\win- > release\build\Source\WebCore\css\CSSPrimitiveValueMappings.h(613): error > C2065: 'CSSValueAttachment' : undeclared identifier > (C:\cygwin\home\buildbot\slave\win- > release\build\WebKitBuild\Release\obj32\WebCore\DerivedSources\StyleBuilder. > cpp) Fixed with a clean build. But see also Bug 142284, where we are fixing this problem permanently. |