| Summary: | Move the Screen object out of the JS bindings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 523.x (Safari 3) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 14192 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2007-06-16 19:48:16 PDT
Created attachment 15081 [details]
patch
One change from the old code that this patch makes is that the properties of the Screen object used to be DontEnum|ReadOnly and now are DontDelete|ReadOnly. I found no documentation or reason that the screen properties should be non-enumeratable and deletable so I changed them to be just like all the the other js objects we generate. This change is visible in the changed results of the regression tests. Comment on attachment 15081 [details]
patch
r=me
Will the other platforms' projects need to change to accommodate the new file paths? Maybe you should send email to webkit-dev.
|